Skip to content

Commit

Permalink
Simplify AdditionalSharedFrameworkToInstallArguments in workloads-tes…
Browse files Browse the repository at this point in the history
…ting.targets (dotnet#96107)

We can use the same args everwhere and also remove an outdated comment.
  • Loading branch information
akoeplinger authored Dec 18, 2023
1 parent 4dffd80 commit 222d4c5
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions eng/testing/workloads-testing.targets
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,9 @@
</PropertyGroup>

<ItemGroup>
<!--<AdditionalSharedFrameworkToInstallArguments Include="-Version 8.0.0-rc.2.23457.7" />-->
<!-- Required for running apps built with 9.0 sdk, but the sdk does
not yet support *running* with 9.0 sdk -->
<AdditionalSharedFrameworkToInstallArguments Condition="!$([MSBuild]::IsOSPlatform('windows'))" Include="-Version latest -c 8.0 -q daily" />
<AdditionalSharedFrameworkToInstallArguments Condition=" $([MSBuild]::IsOSPlatform('windows'))" Include="-Version latest -Channel 8.0 -Quality daily" />
<AdditionalSharedFrameworkToInstallArguments Include="-Version latest -Channel 8.0 -Quality daily" />

<_DefaultPropsForNuGetBuild Include="Configuration=$(Configuration)" />
<_DefaultPropsForNuGetBuild Include="TargetOS=$(TargetOS)" />
Expand Down

0 comments on commit 222d4c5

Please sign in to comment.