Some icons doesn't appear in version 4.3.0

[Zarek999]

Hello,

Great work with this skin, it is really enjoyable to watch :-)

But I have a problem. I use PhpMyAdmin 4.3.0 and I don't show some major icons (home, quit, ...).
As you can see in this screenshot (in the red zone of the upper left corner):

Have an idea of what is the problem?

[mjohnson8165]

Hi, thanks for the kind words and sorry for the very late response... I have too noticed that problem (and a few others with pagination icons for instance) but can't even dream of getting to work on that for now - it'll be another week or so before i can take a look (really caught up in too many projects atm).

From a short inspection of the page DOM, i can see how the .icon class has a display:none property (which must have been overridden by stuff in case newer versions of pma use different selector names for whatever parent wrapper elements i.e. #navipanellinks for the id of the icons you mentioned).

I use these theme on many machines and with every update, as things started to break and degrade, i died a little inside - but the next patch'll take care of many many things and make at least 1 person happy :)

[ghost]

I came across this issue - to fix most of the problem i done this:

cd /usr/share/phpmyadmin/themes/pma8165/
sudo mv img img_bkp
sudo cp -a ../pmahomme/img .
cd img_bkp
sudo mv *.png ../img
cd pmd
sudo mv * ../../img/pmd

Basically i copied over the theme pmahomme img directory (ships with PMA) and then merged this themes images - so in theory any missing images should display the originals..

This did not show those icons though - so I then edited ./css/common.css.php and added this line of CSS:

#navipanellinks .icon { display:inline-block }

Now everything I need is showing nicely :)

[oscarholst]

I just found out about this theme and i love it! But as you guys already stated, the navipanellinks not displaying was a bit sad.
I'm not sure if my approach was the correct one, but i changed two probable typos in common.css
And i don't see any other icons missing, and pagination works too, @mjohnson8165 mentioned it wasn't working. I'm using PhpMyAdmin V4.2.12
EDIT: I was tired and i did not actually solve it. My bad! Closed the pull request.

[ubermanl]

There's a .icon { display: none } causing the main icons (login, home, etc) to disappear.
/* Hide ALL icons */ .icon {display:none}

I found #4, that intends to fix missing icons. Indeed it does fix them, but it feels like "hiding the icons, to show them in the next line", and then the theme looks... over-iconized.
I fixed it by adding, #navipanellinks .icon, to common.css.php on line 3042.

Hope this helps.