Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collector Refactor #65

Open
neufeldtech opened this issue May 24, 2021 · 0 comments
Open

Collector Refactor #65

neufeldtech opened this issue May 24, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@neufeldtech
Copy link
Collaborator

Consider refactoring to allow enabling/disabling features "per collector".

  • Implement one prometheus collector per feature-set, i.e. one for iscsi stats, one for node metrics, etc. These would likely map 1:1 with each goroutine collection inside the main Collect() method
  • Would allow folks to run with things like the QoSHistogram collection gracefully disabled, as this functionality requires admin privileges on ElementOS 11.x (a bug)
  • Could enable success/error/timeout counters per collector to provide further insights into which api calls are slow
@neufeldtech neufeldtech added the enhancement New feature or request label May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@neufeldtech