Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta-6 Target Pose interpolation does not work with alliance flipping #945

Closed
bhall-ctre opened this issue Dec 20, 2024 · 1 comment · Fixed by #946
Closed

Beta-6 Target Pose interpolation does not work with alliance flipping #945

bhall-ctre opened this issue Dec 20, 2024 · 1 comment · Fixed by #946
Labels
bug Something isn't working

Comments

@bhall-ctre
Copy link
Contributor

bhall-ctre commented Dec 20, 2024

Describe the bug
When the shouldFlipPath boolean supplier returns true, the target pose interpolation does not work. The behavior is that PathPlanner appears to be interpolating in the direction of the original unflipped path.

To Reproduce
Steps to reproduce the behavior:

  1. Update our SwerveWithPathPlanner example to PathPlanner beta-6.
  2. In configureAutoBuilder(), add a logger for the target pose callback:
var targetPoseLogger = NetworkTableInstance.getDefault().getStructTopic("Target Pose", Pose2d.struct).publish();
PathPlannerLogging.setLogTargetPoseCallback(targetPoseLogger);
  1. Run the project in simulation.
  2. Set the alliance to Blue (while "Disconnected") and run autonomous. Use the AdvantageScope Odometry tab to view the "Target Pose" field (use the Connect to Simulator feature).
  3. Set the alliance to Red (while "Disconnected") and re-run autonomous. Use the AdvantageScope Odometry tab to view the "Target Pose", and note the incorrect behavior.

Expected behavior
The behavior on the Red alliance should match the Blue alliance, just flipped.

Screenshots
Below is a zip with a video of the correct (blue) and incorrect (red) behavior.
PathPlanner-beta-6-bug.zip

Versions: (please complete the following information):

  • OS: Windows 11
  • GUI Version: n/a
  • PPLib Version: 2025.0.0-beta-6
  • PPLib Language: Java, C++, Python

Additional context
This issue was likely introduced with the changes in #935.

@bhall-ctre bhall-ctre added the bug Something isn't working label Dec 20, 2024
@bhall-ctre bhall-ctre changed the title Target Pose interpolation does not work with alliance flipping Beta-6 Target Pose interpolation does not work with alliance flipping Dec 20, 2024
@mjansen4857
Copy link
Owner

Yeah, the heading doesn’t get flipped which is now used for interpolation. Oversight on my part. Will try to get fix out asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants