More settings

[solonovamax]

Description

It would be nice if additional settings were offered, past just "send reports automatically" and "ignore wifi scan throttling"

here are some suggestions for settings (some of these were influenced by TowerCollector):

• keep screen on while collecting
• begin collecting at app startup
• begin collecting at device boot (see: Run automatically on device startup #111)
• stop collecting at low battery
• map tile cache size (ie. in mb, how many map tiles are cached on-device before pruning old tiles is attempted)
• scanning intervals (see: Allow changing how often data is recorded #186):
  • location

    NeoStumbler/app/src/main/java/xyz/malkki/neostumbler/scanner/ScannerService.kt

    Lines 79 to 80 in 26a94cb

    	//Try to get new locations every 5 seconds
    	private val LOCATION_INTERVAL = 5.seconds

  • wifi
  • bluetooth
  • cell towers
• uploading to multiple sources (see: Allow sending data to multiple endpoints #124)
• disable scanning in already scanned areas (see: Automatically stop scanning if in area where reports have been created #11)
• maximum age for locations/beacons:
  

  NeoStumbler/app/src/main/java/xyz/malkki/neostumbler/scanner/WirelessScanner.kt

  Lines 36 to 40 in 26a94cb

  	//Maximum age for locations
  	private val LOCATION_MAX_AGE = 20.seconds
  	//Maximum age for beacons
  	private val BEACON_MAX_AGE = 20.seconds

• location accuracy:
  

  NeoStumbler/app/src/main/java/xyz/malkki/neostumbler/scanner/WirelessScanner.kt

  Lines 33 to 34 in 26a94cb

  	//Maximum accuracy for locations, used for filtering bad locations
  	private const val LOCATION_MAX_ACCURACY = 200

• enabling/disabling the recording of different sources
  • bluetooth
  • wifi
  • cell towers
• anonymize/fuzz timestamp data (see: Privacy mode - Don't send out accurate timestamps #168)
  • fuzz timestamp: add random offsets to the timestamps
  • less accurate timestamp: only send timestamps that are accurate to a day/hour. round timestamps to the nearest day/hour & send that instead
• max reports to send in one request (see: Limit the amount of reports to send in one request #130)
• map source (see: Custom map layers #145)

may think of additional ones later. will update if I do.

Suggested implementation

No response

Additional information

No response

New request

• I have checked that a similar feature hasn't been requested yet

[mjaakko]

Could you split this into multiple issues? That way it would be easier to keep track of progress and to have discussions, thanks!

In general I'd prefer to avoid having too many settings and instead have sensible defaults. It becomes kind of pain to test all permutations when there's a lot of settings. But if there's clear benefit of making something configurable, it's not a problem

[solonovamax]

Could you split this into multiple issues? That way it would be easier to keep track of progress and to have discussions, thanks!

I made a master issue as several of these already have their own issues, and also because I didn't want to create a ton of issues on the repo as it's kinda spammy.

In general I'd prefer to avoid having too many settings and instead have sensible defaults. It becomes kind of pain to test all permutations when there's a lot of settings. But if there's clear benefit of making something configurable, it's not a problem

I do agree that sensible defaults are good, however many of these options wouldn't require testing:

• modifying the scan interval: if it works with the default interval, changing that shouldn't break it
• disabling different sources: if everything works with all the sources enabled, there is no reason it would break with them disabled.
• anything where a constant is just looking to be made configurable

also, for many of the cases where "sensible defaults" might apply, I think there are very good justifications for wanting it to be configurable.

• neostumbler could significantly increase battery usage, so changing the scanning interval or disabling scanning sources all together would help improve battery longevity
• some people may want the map cache to be small so as to avoid using too much space, whereas others may want it to be larger as they often find themselves in low-reception areas
• different people might want neostumbler to stop at different battery levels