Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider transitioning to using 'Result' types where possible #13

Open
Amndeep7 opened this issue May 28, 2024 · 0 comments
Open

Consider transitioning to using 'Result' types where possible #13

Amndeep7 opened this issue May 28, 2024 · 0 comments
Labels
nonblocking Not a blocker for any future releases

Comments

@Amndeep7
Copy link
Contributor

Currently we handle errors, validation/assertion failures, and successes in a variety of different ways. Sometimes we return {result: "Success"}, log + throw error up the stack, and/or {success: false, error: "this failed for some reason"}. I think we could become more consistent about things while using a Result type.

Interesting articles/projects:

https://imhoff.blog/posts/using-results-in-typescript
https://github.com/vultix/ts-results

@Amndeep7 Amndeep7 added the nonblocking Not a blocker for any future releases label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nonblocking Not a blocker for any future releases
Projects
None yet
Development

No branches or pull requests

1 participant