Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make version= in plugins {} allow semver contraints #708

Open
j-lanson opened this issue Dec 9, 2024 · 2 comments
Open

make version= in plugins {} allow semver contraints #708

j-lanson opened this issue Dec 9, 2024 · 2 comments
Assignees
Labels
product: hc Relates to the core "hc" binary type: enhancement New feature or request
Milestone

Comments

@j-lanson
Copy link
Collaborator

j-lanson commented Dec 9, 2024

Currently, we have to specify a version for a plugin in the plugins {} which doesn't work well for our config_to_policy conversion, since we don't want to have to update that code every time any of our plugins gets a new version.

Furthermore, it would be generally useful to offer users a way to just get the newest version of a plugin. We should make version= optional in the policy file and grab the newest version when selecting from the plugin's download manifest.

@j-lanson j-lanson added type: enhancement New feature or request product: hc Relates to the core "hc" binary labels Dec 9, 2024
@j-lanson j-lanson added this to the 3.9.0 milestone Dec 9, 2024
@alilleybrinker
Copy link
Collaborator

It's probably better to permit version constraints like the ones offered in Cargo or NPM. Most software ecosystems which permit version constraints have learned over time that wildcard constraints ("just get latest") cause more problems than they solve, because they don't offer any ability for the user to manage breakage.

Cargo and NPM have slightly different operators:

@j-lanson
Copy link
Collaborator Author

Use semver crate to achieve this

@j-lanson j-lanson modified the milestones: 3.9.0, 3.10.0 Dec 19, 2024
@j-lanson j-lanson changed the title make version= in plugins {} optional and get newest from download manifest make version= in plugins {} allow semver contraints Dec 19, 2024
@devin-b-lake devin-b-lake self-assigned this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: hc Relates to the core "hc" binary type: enhancement New feature or request
Projects
Status: Todo
Status: No status
Development

No branches or pull requests

3 participants