Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make additional-config-file paths relative to the Hipcheck.kdl file, not to the path the user is in. #611

Open
alilleybrinker opened this issue Nov 9, 2024 · 1 comment
Labels
product: hc Relates to the core "hc" binary

Comments

@alilleybrinker
Copy link
Collaborator

Right now those config paths basically lock the user into running things from a single location, but instead those paths should be relative to the file, not the user.

@j-lanson
Copy link
Collaborator

Because the additional-config paths are arguments to plugins, we don't make any assumptions about their contents before sending them to the plugin during the config step. The plugin has no idea where the Hipcheck.kdl file was located, so it doesn't have the necessary info to resolve any path-representing strings it receives as relative to Hipcheck.kdl.

@alilleybrinker alilleybrinker added the product: hc Relates to the core "hc" binary label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: hc Relates to the core "hc" binary
Projects
Status: Todo
Status: Todo
Development

No branches or pull requests

2 participants