Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag Submission box does not disappear until full page reload #530

Closed
rbclark opened this issue Jul 17, 2020 · 2 comments · Fixed by #539 · May be fixed by #532
Closed

Flag Submission box does not disappear until full page reload #530

rbclark opened this issue Jul 17, 2020 · 2 comments · Fixed by #539 · May be fixed by #532
Labels
bug

Comments

@rbclark
Copy link
Contributor

rbclark commented Jul 17, 2020

Currently when a user submits a flag the Flag Submission box still displays until page reload.

The desired behavior is as follows:

  • Admins can submit the same flag over and over and it should never create a solved challenge, and therefore they will only be shown the text saying "Flag Accepted" but after page reload they will be able to submit again.
  • Players should only be able to submit a flag once, and once they see "Flag Accepted" they should not have the option to resubmit.

Screen Recording 2020-07-17 at 10 58 57 AM

Tests to verify this behavior would be awesome, since admins are unable to verify it by hand without creating a team account.
@rbclark rbclark added the bug label Jul 17, 2020
@camdenmoors
Copy link
Collaborator

Should be fixed with Sean's #532

@sesheikholeslam
Copy link
Contributor

Should be fixed with Sean's #532

Unfortunately I think the fix I made in that PR makes the flag submission box disappear when the user submits both a correct and incorrect flag.

@sesheikholeslam sesheikholeslam mentioned this issue Jul 31, 2020
Merged
camdenmoors added a commit to sesheikholeslam/ctf-scoreboard that referenced this issue Aug 10, 2020
@camdenmoors
Merge branch 'master' into flag-submission-box-disappears-mitre-cyber…
190625b 
…-academy#530
camdenmoors added a commit to sesheikholeslam/ctf-scoreboard that referenced this issue Aug 11, 2020
@camdenmoors
Merge branch 'master' into flag-submission-box-disappears-mitre-cyber…
f0d0fa7 
…-academy#530
@camdenmoors camdenmoors mentioned this issue Aug 17, 2020
Open
@camdenmoors camdenmoors linked a pull request Aug 17, 2020 that will close this issue
Adds Survey to Rate Challenges After Correct Flag Submission #224 #532
Open
camdenmoors added a commit to sesheikholeslam/ctf-scoreboard that referenced this issue Aug 18, 2020
@camdenmoors
Merge branch 'master' into flag-submission-box-disappears-mitre-cyber…
99f4ffb 
…-academy#530
camdenmoors added a commit to sesheikholeslam/ctf-scoreboard that referenced this issue Aug 19, 2020
@camdenmoors
Merge branch 'master' into flag-submission-box-disappears-mitre-cyber…
738dbb3 
…-academy#530
rbclark pushed a commit that referenced this issue Sep 29, 2020
@sesheikholeslam @camdenmoors
Flag Submission Box Disappears After Submitting Correct Flag-#530 (#539)
b08143c 
* Move solvable check into a before_action, add tests

Co-authored-by: Camden Moors <[email protected]>
Co-authored-by: Robert Clark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@rbclark @sesheikholeslam @camdenmoors