This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Add full support for RFB 3.3, with tests. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split handshake() into separate functions - Created ClientIO interface to enable mocking - Added unit tests for clientInit()
|
@mitchellh ping |
|
@kward ping, this have merge conflict |
|
If there is strong interest, I can make this work. The responsiveness to pull requests wasn't great at the time, so I forked and have moved way beyond just this pull request. Feel free to check out my repo where this is already implemented. (https://github.com/kward/go-vnc) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code includes VNCAuth support as provided in the separate DES inclusion pull.
This work is based on the work of xenserverarmy, with some code refactoring.