Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables window not saving/reloading window position properly. #46

Open
kaydeeH opened this issue Oct 31, 2024 · 0 comments
Open

Variables window not saving/reloading window position properly. #46

kaydeeH opened this issue Oct 31, 2024 · 0 comments

Comments

@kaydeeH
Copy link

kaydeeH commented Oct 31, 2024

When you get your monitor all set up the way you like it, close it, and reopen it, it always fails to open the variables window (no error, but the checkbox is not checked so it isn't open). If you open it manually by checking the box, its settings are lost and it opens using the settings for the mode window (they always directly overlap each other).

I'm not set up for branching this project and making a pull request, so my apologies there, but I do know the sources of the issue and the fixes. Looks like an old copy and paste issue that has slid under the radar...

In the mpfmon.py file, improperly references modes window:

self.toggle_variables_window_action = QAction('&Variables', self.device_window,
                                        statusTip='Show the variables window',
                                        triggered=self.toggle_mode_window) 

Also In the mpfmon.py file, missing a reference to the variables window entirely:

monitor_windows = {
            'devices': self.device_window,
            'pf': self.view,
            'modes': self.mode_window,
            'events': self.event_window,
            'inspector': self.inspector_window
        }

In variables.py, improperly references modes window:

        self.ui.move(self.mpfmon.local_settings.value('windows/modes/pos',
                                                   QPoint(1100, 200)))
        self.ui.resize(self.mpfmon.local_settings.value('windows/modes/size',
                                                     QSize(300, 240)))

Found in MPF-Monitor 0.57.1. Fixing those got it working as expected for me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant