Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX FOR #375
When using a
image: load: mode_start
configuration to load image assets on mode start and unload on mode end, a Widget hosting the Image will crash MC.widgets/image.py
By the time
prepare_for_removal()
is called, the Image asset has already been unloaded from the image widget soself._image.image
isNone
, which causes a crash:AttributeError: 'NoneType' object has no attribute 'anim_reset'
This PR works around the error by wrapping the
prepare_for_removal()
with an exception catch and ignore it on AttributeError.