Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HumanPerceptionCheckCommand #73

Open
miron opened this issue Mar 6, 2023 · 1 comment
Open

Fix HumanPerceptionCheckCommand #73

miron opened this issue Mar 6, 2023 · 1 comment

Comments

@miron
Copy link
Owner

miron commented Mar 6, 2023 •
edited
Loading

Lots of dependencies removed, SkillCheckCommand gets self.player now from Map and is a singleton. Questionable if HumanPerceptionCheckCommand class is still needed, look at uuid code, maybe separate class to get player and all npc positions
@miron miron added this to NeonCore Mar 6, 2023
@miron miron moved this to 🏗 In progress in NeonCore Mar 6, 2023
@miron
Copy link
Owner Author

miron commented Mar 8, 2023

Removed assignment of self.player as it is passed by the ActionManager, skillcheck now in superclass.
Check works, but only after move AND encounter. (npc needs to be passed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
NeonCore
Status: 🏗 In progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@miron