Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brawling needs additional work #71

Closed
miron opened this issue Mar 5, 2023 · 2 comments
Closed

Brawling needs additional work #71

miron opened this issue Mar 5, 2023 · 2 comments

Comments

@miron
Copy link
Owner

miron commented Mar 5, 2023 •
edited
Loading

Brawling needs additional work

  • skill_value for npc takes individual d6 rolls into account but is missing the d10 roll.
  • Player uses skill_total() from Character, but the last value for brawling is the number of d6 rolls.

Originally posted by @miron in #67 (comment)
@miron miron added this to NeonCore Mar 5, 2023
@miron miron moved this to 🏗 In progress in NeonCore Mar 5, 2023
@miron
Copy link
Owner Author

miron commented Mar 5, 2023

Removed d6 values from pregens as not part at later stage of game development.
d10 roll could be added to handle_npc_encounter, but thinking if NPCEncounter class is necessary, as all NPC encounters are skill checks anyway, and story NPCs are part of the story modules

@miron
Copy link
Owner Author

miron commented Mar 6, 2023

moved to SkillCheckCommand, d10 roll needs to be added in skill_check, and if statement for npc’s

@miron miron closed this as completed Mar 8, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in NeonCore Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
NeonCore
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@miron