Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPCEncounterCommand has skill_value of 0 #67

Open
miron opened this issue Feb 20, 2023 · 2 comments
Open

NPCEncounterCommand has skill_value of 0 #67

miron opened this issue Feb 20, 2023 · 2 comments

Comments

@miron
Copy link
Owner

miron commented Feb 20, 2023

instantiated in do_use_skill, but skill_value is set in instance from Move.move.
@miron miron added this to NeonCore Feb 20, 2023
@miron miron moved this to 🏗 In progress in NeonCore Feb 20, 2023
@miron miron mentioned this issue Feb 20, 2023
Closed
@miron miron changed the title NPCEncounter has skill_value of 0 NPCEncounterCommand has skill_value of 0 Mar 5, 2023
@miron
Copy link
Owner Author

miron commented Mar 5, 2023

Brawling needs additional work

  • skill_value for npc takes individual d6 rolls into account but is missing the d10 roll.
  • Player uses skill_total() from Character, but the last value for brawling is the number of d6 rolls.

@miron miron mentioned this issue Mar 5, 2023
Closed
@miron
Copy link
Owner Author

miron commented Mar 6, 2023 •
edited
Loading

Removed d6, d10 for NPC needs to be implemented in skill_check, with if statement to check if npc skill or DV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
NeonCore
Status: 🏗 In progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@miron