Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: retransmit via tcp as well #170

Closed
hannesm opened this issue Jun 30, 2019 · 2 comments
Closed

server: retransmit via tcp as well #170

hannesm opened this issue Jun 30, 2019 · 2 comments
Milestone
2.0.0

Comments

@hannesm
Copy link
Member

hannesm commented Jun 30, 2019

only when the other side on dns protocol level acknowledget our dns message, stop the retransmission. unsure whether this is treat correctly atm, need to review
@hannesm hannesm added this to the 2.0.0 milestone Jun 30, 2019
@hannesm
Copy link
Member Author

hannesm commented Jul 4, 2019

at least the secondary (in dns_mirage_server.ml) has atm a tcp_packet_transit(which is never cleared/data removed) -- which should be replaced by proper retransmission logic in Dns_server.Secondary

@hannesm hannesm mentioned this issue Aug 7, 2019
Merged
@hannesm
Copy link
Member Author

hannesm commented Aug 7, 2019

after re-viewing the code, this turns out to be a non-issue (and tcp_packet_transit is removed in #184)

@hannesm hannesm closed this as completed Aug 7, 2019
RyanGibb pushed a commit to RyanGibb/ocaml-dns that referenced this issue Sep 26, 2022
@Leonidas-from-XIV
Merge pull request mirage#170 from Leonidas-from-XIV/stdcompat.18dune3
bfd929d 
[new release] stdcompat.18+dune3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@hannesm