From 008dc28a2df4bc8a4f067a28a2ea0e1e436e88a6 Mon Sep 17 00:00:00 2001
From: kapsner <lorenz.kapsner@gmail.com>
Date: Tue, 4 Jun 2024 16:55:15 +0200
Subject: [PATCH] fix: fixed issue with copying of final pdf-report

---
 DESCRIPTION           |  4 ++--
 NEWS.md               | 16 +++++++++++++++-
 R/create_pdf_report.R |  2 +-
 data-raw/devstuffs.R  |  2 +-
 4 files changed, 19 insertions(+), 5 deletions(-)

diff --git a/DESCRIPTION b/DESCRIPTION
index f8baf09..e8f7fd4 100644
--- a/DESCRIPTION
+++ b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: DQAstats
 Title: Core Functions for Data Quality Assessment
-Version: 0.3.4.9007
-Date: 2024-06-03
+Version: 0.3.4.9008
+Date: 2024-06-04
 Authors@R: c(
     person("Lorenz A.", "Kapsner", , "lorenz.kapsner@gmail.com", role = c("cre", "aut"),
            comment = c(ORCID = "0000-0003-1866-860X")),
diff --git a/NEWS.md b/NEWS.md
index f78eed2..8a0ffa1 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -60,6 +60,20 @@
 
 #### Other changes
 
+-   reverted rv_list to rv again
+    ([f44a854](https://gitlab.miracum.org/miracum/dqa/dqastats/tree/f44a854c6b7e70ee23eb6baadde6ed55422c67b7))
+-   removed as.list(rv) again
+    ([017bb49](https://gitlab.miracum.org/miracum/dqa/dqastats/tree/017bb49ecdd01d60015137119c2612a6a90213a7))
+-   changed report-generation
+    ([ac07d40](https://gitlab.miracum.org/miracum/dqa/dqastats/tree/ac07d40f1145015051873ca08a0ea1590839b101))
+-   merged both branches
+    ([7aa766f](https://gitlab.miracum.org/miracum/dqa/dqastats/tree/7aa766f0bf62f42c4e47ddcff775bfec74b42af6))
+-   fixed errors
+    ([8702985](https://gitlab.miracum.org/miracum/dqa/dqastats/tree/870298524d5437a8896c128204acb85948e873ed))
+-   re-introduced missing pdf-copying
+    ([4f6a7d5](https://gitlab.miracum.org/miracum/dqa/dqastats/tree/4f6a7d52c78b005a9bf0d2ebbb6e5c4f4562807f))
+-   fixed all changes that have not been merged before
+    ([d370e06](https://gitlab.miracum.org/miracum/dqa/dqastats/tree/d370e069d0c0cc1795ec54955a46aad24f9af27b))
 -   added latest enhancements from dev-branch
     ([55b011b](https://gitlab.miracum.org/miracum/dqa/dqastats/tree/55b011b27c8535f82f3fbecd89529b728ae15452))
 -   updated dev-stuffs
@@ -90,7 +104,7 @@
     ([d1f2610](https://gitlab.miracum.org/miracum/dqa/dqastats/tree/d1f2610048a79b42b0a5036e12b25f87e3976d14))
 
 Full set of changes:
-[`v0.3.4...55b011b`](https://gitlab.miracum.org/miracum/dqa/dqastats/-/compare/v0.3.4...55b011b)
+[`v0.3.4...f44a854`](https://gitlab.miracum.org/miracum/dqa/dqastats/-/compare/v0.3.4...f44a854)
 
 ## v0.3.4 (2024-04-04)
 
diff --git a/R/create_pdf_report.R b/R/create_pdf_report.R
index fdf81b8..ff60d0e 100644
--- a/R/create_pdf_report.R
+++ b/R/create_pdf_report.R
@@ -235,7 +235,7 @@ create_pdf_report <- function(rv = rv,
         metadata_file = params_file
       )
 
-      pdf_temp_file <- gsub("\\.Rmd$", ".pdf", template_file)
+      pdf_temp_file <- gsub("\\.qmd$", ".pdf", template_file)
 
       file.copy(
         from = pdf_temp_file,
diff --git a/data-raw/devstuffs.R b/data-raw/devstuffs.R
index dbcff93..e426671 100644
--- a/data-raw/devstuffs.R
+++ b/data-raw/devstuffs.R
@@ -26,7 +26,7 @@ my_desc$set_authors(c(
 # Remove some author fields
 my_desc$del("Maintainer")
 # Set the version
-my_desc$set_version("0.3.4.9007")
+my_desc$set_version("0.3.4.9008")
 
 # The title of your package
 my_desc$set(Title = "Core Functions for Data Quality Assessment")