Fixes for empty tables

[madelondohmen]

Changes

• Removes the bulk action button when the report history table is empty
• Removes the empty findings table on the Crisis Room page and replace with an empty state text

The format of the code has changed, which might make the changed files hard to understand.
The only things I've added are if-statements around the tables to check if there's data

Issue link

Closes #3843

Demo

QA notes

• Do a make reset
• Check the crisis room --> Table shouldn't be visible, but instead you should see an empty state text
• Check the report history page --> Bulk action button shoudn't be visible

---

Code Checklist

• All the commits in this PR are properly PGP-signed and verified.
• This PR only contains functionality relevant to the issue.
• I have written unit tests for the changes or fixes I made.
• I have checked the documentation and made changes where necessary.
• I have performed a self-review of my code and refactored it to the best of my abilities.

• Tickets have been created for newly discovered issues.
• For any non-trivial functionality, I have added integration and/or end-to-end tests.
• I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
• I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

---

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

---

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

[ppvg]

Are "findings" found? Or would something like "no findings have been made yet" make more sense?

[madelondohmen]

Are "findings" found? Or would something like "no findings have been made yet" make more sense?

@ppvg This is the same text that we use in the Findings Report when there's no data.
@stephanie0x00 What do you think about this? If we want to change it, we should change it everywhere.

[TwistMeister]

Checklist for QA:

• I have checked out this branch, and successfully ran a fresh make reset.
• I confirmed that there are no unintended functional regressions in this branch:
  • I have managed to pass the onboarding flow
  • Objects and Findings are created properly
  • Tasks are created and completed properly
• I confirmed that the PR's advertised feature or hotfix works as intended.
• I checked the logs for errors and/or warnings and made issues where necessary

What works:

The 2 listed scenario's work

Bug or feature?:

• The "Crisis room" across all organizations still shows 2 "empty" (count = 0) tables instead of text. Not sure if intended?

[stephanie0x00]

Are "findings" found? Or would something like "no findings have been made yet" make more sense?

@ppvg This is the same text that we use in the Findings Report when there's no data. @stephanie0x00 What do you think about this? If we want to change it, we should change it everywhere.

We should definitely update the text. It is quite complicated and nuanced though. For now we can update it to: "No findings have been identified yet.". We probably have to type out the nuances on the docs and make a reference to this page from the reports.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud