-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cron for last day of the month #3831
Conversation
…om/minvws/nl-kat-coordination into feature/add-start-time-to-schedule
A tip for the next time: It's a bit hard to review this since there's duplicate code due to merging of I think it would've been better to branch from |
Checklist for QA:
What works:Seems to work. What doesn't work:n/a Bug or feature?:n/a |
Quality Gate passedIssues Measures |
* main: (60 commits) Increase max number of PostgreSQL connections (#3889) Fix for task id as valid UUID (#3744) Add `auto_calculate_deadline` attribute to Scheduler (#3869) Ignore specific url parameters when following location headers (#3856) Let mailserver inherit l1 (#3704) Change plugins enabling in report flow to checkboxes (#3747) Fix rocky katalogus tests and delete unused fixtures (#3884) Enable/disable scheduled reports (#3871) optimize locking in katalogus.py, reuse available data (#3752) Updates boefje clearances and descriptions (#3863) Fixes for empty tables (#3844) Fix cron for last day of the month (#3831) Sub reports for Aggregate Report (#3852) Add start time to scheduled reports (#3809) Add configuration setting for number of octopoes workers (#3796) Limit requesting prior tasks for ranking in scheduler (#3836) Let local plugins (files) take precedence over database entries (#3858) Skip empty queues in the Rocky worker (#3860) Report types listed in a modal @ report plugins (#3718) Support a Schedule without a schedule in scheduler (#3834) ...
Note: This PR is based on PR #3809
Changes
Small fix when the start day is the 28th, 29th, 30th or 31st of the month. Will be processed as the last day of the month ("L").
Issue link
Closes #3810
Demo
Please add some proof in the form of screenshots or screen recordings to show (off) new functionality, if there are interesting new features for end-users.
QA notes
h m L * *
where h is the hour, m the minute and L should be "L"Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.