-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add live set (filter/query) to ReportRecipe #3769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny remarks/ suggestions
Co-authored-by: ammar92 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but there's just one test that's broken. But should be ready for testing
…ws/nl-kat-coordination into feature/report-recipe-query
Checklist for QA:
What works:Seems to work. Created a live filter and scheduled a report, removed the objects from the object list to check if the report contained less objects on the next run. Added a new object to see if it was picked up. What doesn't work:n/a Bug or feature?:
|
Quality Gate failedFailed conditions |
Changes
This PR makes it possible to continue in the report recipe flow with the selected filters (as a query), instead of selecting OOI's manually from the table.
Issue link
Closes ...
Demo
The schedule:
The edit report page shows that the input_recipe now contains a "query" instead of "input_oois"
After adding a new Hostname (L2), the generated report contained 3 objects instead of 2:
QA notes
Please add some information for QA on how to test the newly created code.
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.