-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move test web server startup/shutdown to the GitHub Actions workflow #22
Comments
Another downside:
On the positive side:
|
The default port can be specified through the environment variable (as we do with other test-related stuff) in the |
Interestingly, the original process bound to that port would receive the requests. For some reason PHP doesn't complain that the port is already in use. Worst case is that the original server's purpose was unrelated to these tests, so the tests start failing, confusing the user. But that case would happen anyway with the old manual flow.
They'll need to change that in the config then. That also applies to other ports (e.g. defined in docker).
Fixed in #23.
Will be fixed #34 and documentation improved in #19. A small reminder of why this was done: we should strive for the simplest way possible for contributors to start out. This is why we use tools like package managers, containerisation and so on. With all that, I feel that this issue can be closed. |
Currently, the https://github.com/minkphp/webdriver-classic-driver/blob/main/tests/bootstrap.php file automatically starts/stops the web server with test fixtures used during testing. This is an innovative approach compared to how other drivers would do this.
If we go away from the current approach (start web server inside a test suite), then all that stuff needs to be moved into the GitHub Actions workflow (as in other drivers).
Possible downsides to the current approach (I'm not saying it's a wrong approach in general):
phpunit.xml
.The text was updated successfully, but these errors were encountered: