Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Allow replacing the license text with SPDX License Identifier #19

Open
sarahec opened this issue Jun 21, 2022 · 4 comments
Open
Assignees
Labels
feature New feature or change request

Comments

@sarahec
Copy link

sarahec commented Jun 21, 2022

Contact Details

[email protected]

Plugin Version

1.0.12

What do you propose?

It would be useful to add the SPDX-License-Identifier below the copyright. The question I have is should we make this an option in the settings? I'm happy to submit a PR.

@sarahec sarahec added feature New feature or change request triage Issue needs to be reviewed labels Jun 21, 2022
@minherz
Copy link
Owner

minherz commented Jun 22, 2022

Hi,
I am not aware of a need to have both SPDX identifier and license text in the same file. The lint-like solutions either validate the presence of the license code with optional copyright verification or looking for SPDX identifier but not for both.
Can you elaborate a use case where having such identifier is required?

Regarding your question, if such an option will be added, it has to be an opt-in option.

@minherz minherz added question Further information is requested and removed triage Issue needs to be reviewed labels Jun 22, 2022
@sarahec
Copy link
Author

sarahec commented Jun 22, 2022

Ah, I misunderstood how the license identifier works. Thanks for clarifying.

@sarahec sarahec closed this as completed Jun 22, 2022
@sarahec
Copy link
Author

sarahec commented Jun 22, 2022

After discussion off-line, we've decided to make this an either-or switch: either it's the full license text or it's a copyright and license header. I"ll set up a PR.

@sarahec sarahec reopened this Jun 22, 2022
@minherz minherz changed the title [FR]: [FR]: Allow replacing the license text with SPDX License Identifier Jun 30, 2022
@minherz minherz removed the question Further information is requested label Jun 30, 2022
@minherz
Copy link
Owner

minherz commented Aug 28, 2022

I suggest to have this as a checkbox configuration that controls whether to add the full license text or the SPDX id only. Copyright info should be added anyway.

@minherz minherz assigned sarahec and unassigned minherz Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or change request
Projects
None yet
Development

No branches or pull requests

2 participants