Version 4.0.0 candidate #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as done on the API.
…of http requests (maybe DownloadList in the future).
…re used. Also typo in lang.
…It seems that it's an issue with timeouts, because even when request succeeds the request cames only after timeout.
…e displaying when overflowing of terminal.
…ithout a DownloadTask
…or handler to avoid crashing when invalid characters are spilled by Minecraft #133
… and only used for debugging purposes.
…hope so). Also reading all buffer on any non 200 code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #146
Changes
API: Full rewrite of the API (except for authentication), brand-new installation process and configuration, supporting event-based diagnostics (#114)
API: New fixes API allowing fixing previse components on demand
API: Fixing LWJGL to a specific version is now included in the API, through the new fixes API
API: Support for fixing LWJGL to version 3.3.2 (#148, thanks @snoopchallenge)
API: Fixing wrong JVM executable path on macOS (#156, #149, thanks @allen546 and @plushTeddy)
API: Fixing multiplayer button being disabled in offline mode for versions 1.16.4 and 1.16.5 (#154, thanks @unaiiglesias)
API: Supporting quick play arguments on modern versions, with retro-compatible support for older ones (#153, thanks @cunhar)
API: Better internal HTTP request API, with easier response and error handling
API: Fabric and Quilt now included by default in the API
API: Forge now included by default in the API
API: Forge installation is no longer running the installer manually, it instead read its inner metadata and manually run processors if required, supporting all versions providing an installer (#133, thanks @rutexd)
API: Resources downloading is no parallelized, much, much faster!
CLI: Wider support of the
--timeoutargumentCLI: Output format can be selected using the
--outputargument, supporting by defaulthumanandmachineoutputs, and the defaulthuman-colorwith a bit of coloringCLI: Verbosity can be set using one or more
-vflag, mostly supported bystartcommandCLI: Search command has no more
-l(--local) flag, instead a-k(--kind) has been introduced that support searching formojang(like before),local(equivalent of old-lflag),forge,fabricandquiltmod loader versionsCLI: On start, login and logout commands, the
-m(--microsoft) has been replaced with--auth-service, which now defaults to Microsoft, but still support YggdrasilCLI: Start flag
--anonymisehas been replaced by--auth-anonymizeCLI: Start flag
--no-old-fixreplaced with--no-fix, because fixes now also applies to modern versionsCLI: Start argument
--lwjgladditionally support version 3.3.2CLI: Start argument
--resolrenamed--resolutionCLI: When starting the game, the game's logs are now formatted by the launcher itself with better Ctrl-C support, therefore the flag
--no-better-logginghas been removedCLI: Fixed Ctrl+C on Windows (#133)
CLI: No add-on support, for now
Doc: Documentation has been fully reworked, both for CLI and API!
Dev: The repository is no longer a mono-repo, everything interesting will be included directly in the launcher now
Dev: Launcher's sources are no better separated in proper modules
Dev: Improved GitHub workflow to avoid running for doc changes
Dev: Now requiring poetry 1.2 at least, and added pytest/toml tests requirements
Contrib: Additional thanks to @Ristovski and @GoodDay360 for their feedbacks! And @TickingFeather for fixing typo in documentation!