Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality of popular basic plugins in core #211

Open
6 of 7 tasks
patriksh opened this issue Apr 12, 2020 · 10 comments
Open
6 of 7 tasks

Add functionality of popular basic plugins in core #211

patriksh opened this issue Apr 12, 2020 · 10 comments

Comments

@patriksh
Copy link
Contributor

patriksh commented Apr 12, 2020

  • Google Analytics
  • Google Maps plugin
  • Rich Edit plugin
  • More Edit plugin
  • Admin Tools - Login
  • PHP info
  • GDPR plugin

These plugins don't need frequent updates or don't need updates at all, they're lightweight and essential.

They should be integrated in the core.

More plugin suggestions welcome.

Related: #197

@eurobank
Copy link

Well RichEdit is so old, like something of 5 years back version of TinyMCE.

Also it seems there are TWO versions of TinyMCE, i wonder why. One for the admin and one as a plugin. Could that be only one?

@patriksh
Copy link
Contributor Author

Well RichEdit is so old, like something of 5 years back version of TinyMCE.

Also it seems there are TWO versions of TinyMCE, i wonder why. One for the admin and one as a plugin. Could that be only one?

I'll update the admin version if needed and use it for frontend as well.

@eurobank
Copy link

@webmods-croatia

Keep in mind that i do remember an old topic from the Osclass forum(God rest his soul), @dev101 had said that you can't properly intergrate any editor. And the rich edit plugin was actually a hack.

I'm not a dev and i have no idea what was the meaning of that. Just saying.

@patriksh
Copy link
Contributor Author

@webmods-croatia

Keep in mind that i do remember an old topic from the Osclass forum(God rest his soul), @dev101 had said that you can't properly intergrate any editor. And the rich edit plugin was actually a hack.

I'm not a dev and i have no idea what was the meaning of that. Just saying.

Saving the item description was a hack indeed, but no need for that when we can modify any core file we need to.

@262925
Copy link

262925 commented Apr 20, 2020

1.I recommend CKEditor instead of Rich Edit plugin.
2. Google map is good but now a days google asking billing method. And Are you sure normal user will ready to provide their card information to google for just google map?

@patriksh
Copy link
Contributor Author

1.I recommend CKEditor instead of Rich Edit plugin.
2. Google map is good but now a days google asking billing method. And Are you sure normal user will ready to provide their card information to google for just google map?

  1. Thanks for the suggestion, I'll check it.
  2. I completely forgot about it, I just added my card info and I never get billed because I don't pass the limit...
    Maybe we should include both Open Street Maps and Google Maps.

@navjottomer
Copy link
Member

For maps, it's better to only include geocoding from Open Street Maps( with a filter to override it to implement 3rd party provider ) and leave map implementation on themes and plugins. There is no need to include the whole plugin into osclass core

@patriksh
Copy link
Contributor Author

For maps, it's better to only include geocoding from Open Street Maps( with a filter to override it to implement 3rd party provider ) and leave map implementation on themes and plugins. There is no need to include the whole plugin into osclass core

Ok, but I would still make a helper to show the map (Open Street Maps/Google) that can be used in admin and in themes.

@arcsales
Copy link

Proper listing moderation.
Extend categories to support special categories like Jobs, Cars etc. For example you have to hide the price fields in Jobs category and regarding cars... you should be able to predefine car makes and car models. I have some old plugins for cars and edited them to suite some of my other categories like mobile phones where you also need nested custom fields.
Build in bumpup, promotional and Top listings options with basic paypal acceptance.

@patriksh
Copy link
Contributor Author

patriksh commented Oct 2, 2021

@navjottomer Working on GDPR + Cookie notice at the moment.

Should I add the GDPR checkboxes and the cookie modal as a part of the core, or just make helpers which should be used by themes?

I will need to add an extra column to the user table, what do I need to do to make it work when upgrading from previous versions?
Same question but for mail templates, I'll need one of those as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants