-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality of popular basic plugins in core #211
Comments
Well RichEdit is so old, like something of 5 years back version of TinyMCE. Also it seems there are TWO versions of TinyMCE, i wonder why. One for the admin and one as a plugin. Could that be only one? |
I'll update the admin version if needed and use it for frontend as well. |
@webmods-croatia Keep in mind that i do remember an old topic from the Osclass forum(God rest his soul), @dev101 had said that you can't properly intergrate any editor. And the rich edit plugin was actually a hack. I'm not a dev and i have no idea what was the meaning of that. Just saying. |
Saving the item description was a hack indeed, but no need for that when we can modify any core file we need to. |
1.I recommend CKEditor instead of Rich Edit plugin. |
|
For maps, it's better to only include geocoding from Open Street Maps( with a filter to override it to implement 3rd party provider ) and leave map implementation on themes and plugins. There is no need to include the whole plugin into osclass core |
Ok, but I would still make a helper to show the map (Open Street Maps/Google) that can be used in admin and in themes. |
Proper listing moderation. |
@navjottomer Working on GDPR + Cookie notice at the moment. Should I add the GDPR checkboxes and the cookie modal as a part of the core, or just make helpers which should be used by themes? I will need to add an extra column to the user table, what do I need to do to make it work when upgrading from previous versions? |
These plugins don't need frequent updates or don't need updates at all, they're lightweight and essential.
They should be integrated in the core.
More plugin suggestions welcome.
Related: #197
The text was updated successfully, but these errors were encountered: