org fixes change vertico globally?

[georgek]

Since the org-agenda related stuff wasn't working properly, I applied the fixes suggested in the README, like so:

  (defun org-enforce-basic-completion (&rest args)
    (minibuffer-with-setup-hook
        (:append
         (lambda ()
           (let ((map (make-sparse-keymap (current-local-map))))
             (define-key map [tab] #'minibuffer-complete)
             (use-local-map map))
           (setq-local completion-styles (cons 'basic completion-styles)
                       vertico-preselect 'prompt)))
      (apply args)))
  (advice-add #'org-make-tags-matcher :around #'org-enforce-basic-completion)
  (advice-add #'org-agenda-filter :around #'org-enforce-basic-completion))

Perhaps I don't fully understand the intention here, but this seems to set [tab] to #'minibuffer-complete globally, not just when using org agenda. Is this correct?

[georgek]

After a bit of fiddling and remember how keymaps work I've come up with this version which seems to work properly:

  (defun org-enforce-basic-completion (&rest args)
    (minibuffer-with-setup-hook
        (:append
         (lambda ()
           (let ((map (make-sparse-keymap)))
             (set-keymap-parent map (current-local-map))
             (keymap-set map "<tab>" #'minibuffer-complete)
             (use-local-map map))
           (setq-local completion-styles (cons 'basic completion-styles)
                       vertico-preselect 'prompt)))
      (apply args)))

[minad]

Thanks, updated in 8cd5e5a.