Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add json key inverted index in stats for optimization #38039

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

support load json index after loadsegment

223a346
Select commit
Loading
Failed to load commit list.
Refresh
Open

enhance: Add json key inverted index in stats for optimization #38039

support load json index after loadsegment
223a346
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 6, 2025 in 1s

68.62% (target 77.00%)

View this Pull Request on Codecov

68.62% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 37.06806% with 601 lines in your changes missing coverage. Please review.

Project coverage is 68.62%. Comparing base (ee9a279) to head (223a346).

Files with missing lines Patch % Lines
...rnal/core/src/exec/expression/JsonContainsExpr.cpp 4.04% 285 Missing ⚠️
internal/core/src/exec/expression/UnaryExpr.cpp 3.44% 56 Missing ⚠️
internal/core/src/indexbuilder/index_c.cpp 0.00% 42 Missing ⚠️
...ernal/core/src/exec/expression/BinaryRangeExpr.cpp 5.55% 34 Missing ⚠️
internal/core/src/exec/expression/TermExpr.cpp 17.50% 33 Missing ⚠️
internal/core/src/segcore/segment_c.cpp 0.00% 33 Missing ⚠️
internal/core/src/common/jsmn.h 78.52% 32 Missing ⚠️
internal/core/src/exec/expression/ExistsExpr.cpp 6.66% 28 Missing ⚠️
internal/core/src/index/JsonKeyInvertedIndex.cpp 88.40% 16 Missing ⚠️
...ternal/core/src/segcore/ChunkedSegmentSealedImpl.h 0.00% 14 Missing ⚠️
... and 5 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38039      +/-   ##
==========================================
- Coverage   69.52%   68.62%   -0.91%     
==========================================
  Files         296      299       +3     
  Lines       26553    27422     +869     
==========================================
+ Hits        18462    18818     +356     
- Misses       8091     8604     +513
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.62% <37.06%> (-0.91%) ⬇️
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
...nternal/core/src/exec/expression/BinaryRangeExpr.h 94.00% <ø> (ø)
internal/core/src/exec/expression/ExistsExpr.h 100.00% <ø> (ø)
internal/core/src/exec/expression/Expr.h 70.42% <100.00%> (+0.42%) ⬆️
...ternal/core/src/exec/expression/JsonContainsExpr.h 100.00% <ø> (ø)
internal/core/src/exec/expression/TermExpr.h 85.71% <ø> (ø)
internal/core/src/exec/expression/UnaryExpr.h 68.51% <ø> (ø)
internal/core/src/index/JsonKeyInvertedIndex.h 100.00% <100.00%> (ø)
internal/core/src/segcore/SegmentInterface.h 71.15% <ø> (ø)
internal/core/src/segcore/SegmentSealed.h 100.00% <ø> (ø)
internal/core/src/segcore/SegmentSealedImpl.h 57.14% <ø> (ø)
... and 17 more

... and 3 files with indirect coverage changes

View more details on Codecov