Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: search req transfer correctly #38955

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix: search req transfer correctly #38955

merged 1 commit into from
Jan 3, 2025

Conversation

chasingegg
Copy link
Contributor

@chasingegg chasingegg commented Jan 2, 2025 •
edited
Loading

issue: #37899

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 2, 2025
@sre-ci-robot sre-ci-robot requested review from aoiasd and yah01 January 2, 2025 10:44
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 2, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025

@chasingegg Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025

@chasingegg cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025

@chasingegg go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chasingegg chasingegg mentioned this pull request Jan 2, 2025
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025

@chasingegg go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Jan 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.14%. Comparing base (accfacf) to head (95b8e60).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38955      +/-   ##
==========================================
+ Coverage   81.13%   81.14%   +0.01%     
==========================================
  Files        1385     1387       +2     
  Lines      196070   196269     +199     
==========================================
+ Hits       159083   159266     +183     
- Misses      31397    31416      +19     
+ Partials     5590     5587       -3
Components Coverage Δ
Client 79.12% <ø> (ø)
Core 69.54% <ø> (+0.07%) ⬆️
Go 83.11% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/querynodev2/delegator/delegator.go 86.69% <100.00%> (+0.02%) ⬆️

... and 40 files with indirect coverage changes

@chasingegg
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Jan 2, 2025
sre-ci-robot pushed a commit that referenced this pull request Jan 3, 2025
@chasingegg
fix: search req transfer correctly (#38954)
018fbb4 
issue: #37899 
pr: #38955

Signed-off-by: chasingegg <[email protected]>
@czs007
Copy link
Collaborator

czs007 commented Jan 3, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d9ebb70 into milvus-io:master Jan 3, 2025
20 checks passed
@chasingegg chasingegg deleted the recall-fix branch January 3, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoiasd aoiasd Awaiting requested review from aoiasd

@yah01 yah01 Awaiting requested review from yah01

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chasingegg @czs007 @sre-ci-robot