Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search req transfer correctly #38954

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

chasingegg
Copy link
Contributor

@chasingegg chasingegg commented Jan 2, 2025

issue: #37899
pr: #38955

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 2, 2025
@mergify mergify bot added the dco-passed DCO check passed. label Jan 2, 2025
Copy link
Contributor

mergify bot commented Jan 2, 2025

@chasingegg Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Jan 2, 2025
Copy link
Contributor

mergify bot commented Jan 2, 2025

@chasingegg Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Jan 2, 2025

@chasingegg go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.04%. Comparing base (6fa096e) to head (0a058eb).
Report is 5 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #38954      +/-   ##
==========================================
- Coverage   81.05%   81.04%   -0.02%     
==========================================
  Files        1383     1383              
  Lines      195503   195518      +15     
==========================================
- Hits       158472   158463       -9     
- Misses      31457    31479      +22     
- Partials     5574     5576       +2     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.45% <ø> (-0.02%) ⬇️
Go 83.03% <100.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/querynodev2/delegator/delegator.go 86.22% <100.00%> (-0.45%) ⬇️

... and 40 files with indirect coverage changes

@chasingegg
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Jan 2, 2025
Copy link
Contributor

mergify bot commented Jan 2, 2025

@chasingegg go-sdk check failed, comment rerun go-sdk can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Jan 3, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 018fbb4 into milvus-io:2.5 Jan 3, 2025
17 of 20 checks passed
@chasingegg chasingegg deleted the recall-fix-2.5 branch January 3, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants