Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add intent ctx to rootcoord init #38948

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

tinswzy
Copy link
Contributor

@tinswzy tinswzy commented Jan 2, 2025

issue: #38439
cherry pick "enhance: add intent ctx to rootcoord init"

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 2, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tinswzy
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jan 2, 2025

@tinswzy Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added dco-passed DCO check passed. do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels Jan 2, 2025
Copy link
Contributor

mergify bot commented Jan 2, 2025

@tinswzy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@tinswzy
Copy link
Contributor Author

tinswzy commented Jan 2, 2025

rerun go-sdk

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.07%. Comparing base (4533fc8) to head (097c48e).
Report is 5 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/rootcoord/root_coord.go 79.31% 1 Missing and 5 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #38948      +/-   ##
==========================================
- Coverage   81.12%   81.07%   -0.06%     
==========================================
  Files        1383     1383              
  Lines      195517   195528      +11     
==========================================
- Hits       158619   158523      -96     
- Misses      31355    31443      +88     
- Partials     5543     5562      +19     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.45% <ø> (ø)
Go 83.05% <89.47%> (-0.07%) ⬇️
Files with missing lines Coverage Δ
internal/rootcoord/dml_channels.go 96.66% <100.00%> (+0.03%) ⬆️
internal/rootcoord/timeticksync.go 84.92% <100.00%> (-1.59%) ⬇️
pkg/log/global.go 100.00% <100.00%> (ø)
pkg/mq/msgstream/common_mq_factory.go 57.14% <100.00%> (ø)
pkg/mq/msgstream/mq_msgstream.go 79.26% <100.00%> (ø)
internal/rootcoord/root_coord.go 88.10% <79.31%> (+<0.01%) ⬆️

... and 31 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 2, 2025

@tinswzy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 2, 2025
@tinswzy
Copy link
Contributor Author

tinswzy commented Jan 3, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 3, 2025

@tinswzy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@tinswzy
Copy link
Contributor Author

tinswzy commented Jan 4, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 4, 2025

@tinswzy go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants