Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: make serialization be part of sync task to support file format change #38946

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Jan 2, 2025

See #38945

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/XXL Denotes a PR that changes 1000+ lines. labels Jan 2, 2025
@sre-ci-robot sre-ci-robot requested review from czs007 and sunby January 2, 2025 09:03
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 2, 2025
Copy link
Contributor

mergify bot commented Jan 2, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 2, 2025

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.54%. Comparing base (acc8fb7) to head (0363073).
Report is 41 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (acc8fb7) and HEAD (0363073). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (acc8fb7) HEAD (0363073)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38946       +/-   ##
===========================================
- Coverage   81.08%   69.54%   -11.54%     
===========================================
  Files        1381      296     -1085     
  Lines      195251    26536   -168715     
===========================================
- Hits       158321    18455   -139866     
+ Misses      31345     8081    -23264     
+ Partials     5585        0     -5585     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.54% <ø> (+0.20%) ⬆️
Go ∅ <ø> (∅)

see 1118 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants