Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: support null expr(#38772) #38931

Open
wants to merge 2 commits into
base: 2.5
Choose a base branch
from

Conversation

smellthemoon
Copy link
Contributor

pr: #38772
issue: #31728

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smellthemoon
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Jan 2, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 2, 2025
Copy link
Contributor

mergify bot commented Jan 2, 2025

@smellthemoon cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 2, 2025

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

lixinguo added 2 commits January 2, 2025 16:14
Signed-off-by: lixinguo <[email protected]>
Signed-off-by: lixinguo <[email protected]>
Copy link
Contributor

mergify bot commented Jan 2, 2025

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@smellthemoon
Copy link
Contributor Author

rerun go-sdk

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 89.62264% with 11 lines in your changes missing coverage. Please review.

Project coverage is 69.54%. Comparing base (4533fc8) to head (0ca36f5).
Report is 5 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/core/src/exec/expression/NullExpr.cpp 90.41% 7 Missing ⚠️
internal/core/src/expr/ITypeExpr.h 55.55% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4533fc8) and HEAD (0ca36f5). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (4533fc8) HEAD (0ca36f5)
3 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #38931       +/-   ##
===========================================
- Coverage   81.12%   69.54%   -11.59%     
===========================================
  Files        1383      296     -1087     
  Lines      195517    26524   -168993     
===========================================
- Hits       158619    18446   -140173     
+ Misses      31355     8078    -23277     
+ Partials     5543        0     -5543     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.54% <89.62%> (+0.09%) ⬆️
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/common/Types.h 29.53% <ø> (ø)
...ernal/core/src/exec/expression/BinaryRangeExpr.cpp 93.01% <ø> (ø)
internal/core/src/exec/expression/Expr.cpp 94.40% <100.00%> (+0.24%) ⬆️
internal/core/src/exec/expression/NullExpr.h 100.00% <100.00%> (ø)
internal/core/src/exec/expression/UnaryExpr.cpp 84.58% <100.00%> (+0.06%) ⬆️
internal/core/src/query/PlanProto.cpp 88.79% <100.00%> (+0.34%) ⬆️
internal/core/src/query/PlanProto.h 18.51% <ø> (ø)
internal/core/src/expr/ITypeExpr.h 46.12% <55.55%> (+0.28%) ⬆️
internal/core/src/exec/expression/NullExpr.cpp 90.41% <90.41%> (ø)

... and 1090 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 2, 2025

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 2, 2025
Copy link
Contributor

mergify bot commented Jan 3, 2025

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants