Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Return io error other than NotExist refreshing config #38924

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: Return io error other than NotExist refreshing config #38924

wants to merge 5 commits into from
+51 −27

Conversation

congqixia
Copy link
Contributor

@congqixia congqixia commented Jan 2, 2025 •
edited
Loading

Related to #38923

This PR:

  • Check whether os.Stat config file error is io.ErrNotExist
  • Panic when get config return error during Milvus initialization

@congqixia
fix: Return io error other than NotExist refreshing config
491e027 
Related to milvus-io#38923

This PR:

- Check whether `os.Stat` config file error is io.ErrNotExist
- Panic if refresher get error

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/S Denotes a PR that changes 10-29 lines. labels Jan 2, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 2, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Jan 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.53%. Comparing base (19a5c31) to head (42bca18).
Report is 11 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (19a5c31) and HEAD (42bca18). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (19a5c31) HEAD (42bca18)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38924       +/-   ##
===========================================
- Coverage   81.13%   69.53%   -11.61%     
===========================================
  Files        1385      296     -1089     
  Lines      196070    26540   -169530     
===========================================
- Hits       159088    18455   -140633     
+ Misses      31393     8085    -23308     
+ Partials     5589        0     -5589
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.53% <ø> (+0.06%) ⬆️
Go ∅ <ø> (∅)

see 1106 files with indirect coverage changes

@congqixia
Copy link
Contributor Author

rerun go-sdk

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@congqixia
Copy link
Contributor Author

go-sdk

@congqixia
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Jan 2, 2025
tedxu
tedxu reviewed Jan 3, 2025
View reviewed changes
pkg/config/refresher.go Outdated Show resolved Hide resolved
pkg/config/file_source.go
if os.IsNotExist(err) {
continue
}
return err
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make sure the err thrown here is properly handled?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to discussion offline, this error shall be handled by caller

@mergify mergify bot removed the ci-passed label Jan 3, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2025

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@tedxu
Copy link
Contributor

tedxu commented Jan 3, 2025

/lgtm

@sre-ci-robot sre-ci-robot removed the lgtm label Jan 3, 2025
@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedxu tedxu tedxu left review comments

@xige-16 xige-16 Awaiting requested review from xige-16

@zwd1208 zwd1208 Awaiting requested review from zwd1208

Assignees

@tedxu tedxu

Labels
approved dco-passed DCO check passed. kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congqixia @sre-ci-robot @tedxu