Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] Release lock when return function #38863

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #38851

master pr: #38856

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 30, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 30, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Dec 30, 2024
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (015e50e) to head (303b590).
Report is 1 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/datacoord/compaction.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #38863      +/-   ##
==========================================
- Coverage   81.05%   81.04%   -0.01%     
==========================================
  Files        1383     1383              
  Lines      195502   195500       -2     
==========================================
- Hits       158462   158443      -19     
- Misses      31463    31481      +18     
+ Partials     5577     5576       -1     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.45% <ø> (ø)
Go 83.02% <0.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/datacoord/compaction.go 71.10% <0.00%> (-0.28%) ⬇️

... and 29 files with indirect coverage changes

@xiaofan-luan xiaofan-luan merged commit 71dea30 into milvus-io:2.5 Dec 30, 2024
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. kind/bug Issues or changes related a bug size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants