Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Release compaction task lock when return function #38856

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #38851

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 30, 2024
Copy link
Contributor

mergify bot commented Dec 30, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.12%. Comparing base (56c5b66) to head (9267a9d).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/compaction.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38856      +/-   ##
==========================================
- Coverage   81.13%   81.12%   -0.01%     
==========================================
  Files        1385     1385              
  Lines      195931   195931              
==========================================
- Hits       158960   158944      -16     
- Misses      31381    31391      +10     
- Partials     5590     5596       +6     
Components Coverage Δ
Client 79.12% <ø> (ø)
Core 69.45% <ø> (-0.01%) ⬇️
Go 83.09% <0.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/datacoord/compaction.go 71.10% <0.00%> (-0.28%) ⬇️

... and 36 files with indirect coverage changes

@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

@czs007
Copy link
Collaborator

czs007 commented Dec 30, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed lgtm size/XS Denotes a PR that changes 0-9 lines. labels Dec 30, 2024
xiaofan-luan pushed a commit that referenced this pull request Dec 30, 2024
@xiaofan-luan xiaofan-luan merged commit af0315f into milvus-io:master Dec 30, 2024
15 of 20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. kind/bug Issues or changes related a bug size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants