Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The "complete plan number" is 0 rather than the completed task number after major compaction completed #38818

Open
1 task done
binbinlv opened this issue Dec 27, 2024 · 3 comments
Assignees
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@binbinlv
Copy link
Contributor

binbinlv commented Dec 27, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version:  xiaocai2333-debug_datacoord_access_timeout-c8ded3d-20241227
- Deployment mode(standalone or cluster): cluster
- MQ type(rocksmq, pulsar or kafka):   pulsar 
- SDK version(e.g. pymilvus v2.0.0rc2): 2.4.13rc5
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

The "complete plan number" is 0 not the completed task number after major compaction completed

CompactionState
 - compaction id: 454895677326769807
 - State: Executing
 - executing plan number: 1
 - timeout plan number: 0
 - complete plan number: 0

waiting for compaction completed
major compaction is successfully in 179.932771 s

CompactionState
 - compaction id: 454895677326769807
 - State: Completed
 - executing plan number: 0
 - timeout plan number: 0
 - complete plan number: 0

after major, segments number is 10

Expected Behavior

The "complete plan number" is the completed task number after major compaction completed

Steps To Reproduce

1. create a collection with 10m data inserted (set is_cluster_key=True to an int64 field)
2. trigger major compaction to this collection

Milvus Log

granfana:
https://grafana-4am.zilliz.cc/d/uLf5cJ3Ga/milvus2-0?orgId=1&from=now-1h&to=now&var-datasource=prometheus&var-cluster=&var-namespace=qa-milvus&var-instance=major-24-ndoap&var-collection=All&var-app_name=milvus

log:
https://grafana-4am.zilliz.cc/explore?orgId=1&panes=%7B%22ITw%22:%7B%22datasource%22:%22vhI6Vw67k%22,%22queries%22:%5B%7B%22refId%22:%22A%22,%22expr%22:%22%7Bcluster%3D%5C%224am%5C%22,namespace%3D%5C%22qa-milvus%5C%22,pod%3D~%5C%22major-24-ndoap.%2A%5C%22%7D%22,%22datasource%22:%7B%22type%22:%22loki%22,%22uid%22:%22vhI6Vw67k%22%7D%7D%5D,%22range%22:%7B%22from%22:%22now-1h%22,%22to%22:%22now%22%7D%7D%7D&schemaVersion=1

Anything else?

collection name: major_compaction_collection_enable_scalar_clustering_key_1kw

@binbinlv binbinlv added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 27, 2024
@binbinlv binbinlv added this to the 2.4.19 milestone Dec 27, 2024
@binbinlv
Copy link
Contributor Author

/assign @xiaocai2333

@binbinlv binbinlv changed the title [Bug]: The "complete plan number" is 0 not the completed task number after major compaction completed [Bug]: The "complete plan number" is 0 rather than the completed task number after major compaction completed Dec 27, 2024
@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 28, 2024
@yanliang567 yanliang567 removed their assignment Dec 28, 2024
@yanliang567 yanliang567 modified the milestones: 2.4.19, 2.4.20 Dec 30, 2024
@xiaocai2333
Copy link
Contributor

After the compaction task is completed, if the clean task goroutine has completed the relevant operations, it will set the tasks state to cleaned. Tasks in the cleaned state will not be returned to the SDK. Therefore, querying task-related information after compaction is completed may result is not being able to retrieve the task information, as it might have already been garbage collected.

@binbinlv
Copy link
Contributor Author

binbinlv commented Jan 2, 2025

So this is as current design?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants