-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: support null expr #38772
enhance: support null expr #38772
Conversation
@smellthemoon go-sdk check failed, comment |
@smellthemoon cpp-unit-test check failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38772 +/- ##
==========================================
+ Coverage 81.13% 81.16% +0.03%
==========================================
Files 1385 1387 +2
Lines 196059 196208 +149
==========================================
+ Hits 159069 159250 +181
+ Misses 31399 31375 -24
+ Partials 5591 5583 -8
|
8d15a8d
to
e15b83f
Compare
@smellthemoon go-sdk check failed, comment |
rerun go-sdk |
} | ||
|
||
ColumnVectorPtr | ||
PhyNullExpr::PreCheckNullable() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this function do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To check if nullable is false, then the TargetBitmap is all true when is_not_null, and all false when is_null.
e15b83f
to
0d16b34
Compare
@smellthemoon E2e jenkins job failed, comment |
/run-cpu-e2e |
Signed-off-by: lixinguo <[email protected]>
Signed-off-by: lixinguo <[email protected]>
0d16b34
to
993e8bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smellthemoon, tedxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#31728