Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: support null expr #38772

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Conversation

smellthemoon
Copy link
Contributor

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Dec 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 26, 2024
Copy link
Contributor

mergify bot commented Dec 26, 2024

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2024

@smellthemoon cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 92.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 81.16%. Comparing base (6b10583) to head (993e8bc).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/exec/expression/NullExpr.cpp 90.41% 7 Missing ⚠️
internal/core/src/expr/ITypeExpr.h 55.55% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38772      +/-   ##
==========================================
+ Coverage   81.13%   81.16%   +0.03%     
==========================================
  Files        1385     1387       +2     
  Lines      196059   196208     +149     
==========================================
+ Hits       159069   159250     +181     
+ Misses      31399    31375      -24     
+ Partials     5591     5583       -8     
Components Coverage Δ
Client 79.12% <ø> (ø)
Core 69.54% <89.62%> (+0.09%) ⬆️
Go 83.13% <100.00%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/common/Types.h 29.08% <ø> (ø)
...ernal/core/src/exec/expression/BinaryRangeExpr.cpp 93.01% <ø> (ø)
internal/core/src/exec/expression/Expr.cpp 94.40% <100.00%> (+0.24%) ⬆️
internal/core/src/exec/expression/NullExpr.h 100.00% <100.00%> (ø)
internal/core/src/exec/expression/UnaryExpr.cpp 84.58% <100.00%> (+0.06%) ⬆️
internal/core/src/query/PlanProto.cpp 88.79% <100.00%> (+0.34%) ⬆️
internal/core/src/query/PlanProto.h 18.51% <ø> (ø)
internal/parser/planparserv2/parser_visitor.go 86.47% <100.00%> (+0.42%) ⬆️
internal/parser/planparserv2/show_visitor.go 93.91% <100.00%> (+0.39%) ⬆️
internal/core/src/expr/ITypeExpr.h 46.12% <55.55%> (+0.28%) ⬆️
... and 1 more

... and 28 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Dec 30, 2024

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@smellthemoon
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Dec 30, 2024
internal/core/src/exec/expression/BinaryRangeExpr.cpp Outdated Show resolved Hide resolved
}

ColumnVectorPtr
PhyNullExpr::PreCheckNullable() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this function do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To check if nullable is false, then the TargetBitmap is all true when is_not_null, and all false when is_null.

internal/core/unittest/test_expr.cpp Show resolved Hide resolved
internal/parser/planparserv2/Plan.g4 Outdated Show resolved Hide resolved
Copy link
Contributor

mergify bot commented Dec 30, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Dec 30, 2024
lixinguo added 2 commits December 31, 2024 12:10
Signed-off-by: lixinguo <[email protected]>
Signed-off-by: lixinguo <[email protected]>
Copy link
Contributor

@tedxu tedxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tedxu
Copy link
Contributor

tedxu commented Jan 2, 2025

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smellthemoon, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 907fc24 into milvus-io:master Jan 2, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants