Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Remove unnecessary clone in meta SetState #37637

Closed
1 task done
bigsheeper opened this issue Nov 13, 2024 · 2 comments
Closed
1 task done

[Enhancement]: Remove unnecessary clone in meta SetState #37637

bigsheeper opened this issue Nov 13, 2024 · 2 comments
Assignees
@bigsheeper
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days

Comments

@bigsheeper
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

The segment has already been cloned, so there is no need to clone it again.
image

Note: This is not a memory leak.
image

Why is this needed?

No response

Anything else?

No response
@bigsheeper bigsheeper added the kind/enhancement Issues or changes related to enhancement label Nov 13, 2024
@bigsheeper bigsheeper self-assigned this Nov 13, 2024
@bigsheeper
Copy link
Contributor Author

related to: #37630

@bigsheeper bigsheeper mentioned this issue Nov 14, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Nov 15, 2024
@bigsheeper
enhance: Remove unnecessary clone in SetState (#37697)
18a6478 
issue: #37637

---------

Signed-off-by: bigsheeper <[email protected]>
@bigsheeper bigsheeper mentioned this issue Nov 16, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Nov 16, 2024
@bigsheeper
enhance: [2.4] Remove unnecessary clone in SetState (#37736)
d295735 
issue: #37637

pr: #37697

Signed-off-by: bigsheeper <[email protected]>
@stale Stale
Copy link

stale bot commented Dec 20, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Dec 20, 2024
@stale stale bot closed this as completed Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bigsheeper bigsheeper

Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bigsheeper