[GITHUB-11915] [Draft / Discussion Only] Add benchmark tasks for GITHUB-11915 changes to facilitate discussion #213
Conversation
| @@ -14409,8 +14409,6 @@ BrowseDayOfYearTaxoFacets: *:* +facets:DayOfYear.taxonomy | |||
| BrowseDateSSDVFacets: *:* +facets:Date.sortedset | |||
| BrowseMonthSSDVFacets: *:* +facets:Month.sortedset | |||
| BrowseDayOfYearSSDVFacets: *:* +facets:DayOfYear.sortedset | |||
| BrowseRandomLabelTaxoFacets: *:* +facets:RandomLabel.taxonomy | |||
There was a problem hiding this comment.
Need to remove these two tasks as index name was getting too long when I tried to include sorting
There was a problem hiding this comment.
I thought @zhaih had made a change to stop building such massive filenames -- maybe it's opt-in (you have to provide your own index name) or so?
There was a problem hiding this comment.
Thanks @mikemccand for the suggestion! I'm not aware of this feature and it does seems like an opt-in to me, but I'll dig around and report back.
There was a problem hiding this comment.
That's actually not added by me, it's there for long time: https://github.com/mikemccand/luceneutil/blob/master/src/python/competition.py#L155
I think just set the name will avoid the overlong auto-generated name.
src/main/perf/LineFileDocs.java
Outdated
| @@ -698,6 +700,23 @@ public Document nextDoc(DocState doc, boolean expected) throws IOException { | |||
| doc.title.setStringValue(title); | |||
| doc.randomLabel.setStringValue(randomLabel); | |||
| if (addDVFields) { | |||
| doc.doc.removeField("quarter"); | |||
| doc.doc.removeField("quarterBDV"); | |||
| int randomInt = RANDOM.nextInt(13); | |||
There was a problem hiding this comment.
isn't this used by multiple threads? do we really want them synchronizing on the same random instance?
There was a problem hiding this comment.
Thanks @rmuir for the review! I was focusing on generating quarter field randomly earlier, and did not realize this is used by multiple threads, but it makes sense to not have threads contention here. I have removed this and related changes to use month for sorting instead per suggestion from apache/lucene#12194 (comment).
This is a draft PR to provide benchmark result for apache/lucene#12194