Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examine in-app-updates from official play store for inspiration #16

Open
mikehardy opened this issue May 8, 2019 · 9 comments
Open
Labels
enhancement New feature or request

Comments

@mikehardy
Copy link
Owner

https://developer.android.com/guide/app-bundle/in-app-updates

Some good ideas here - mostly the UI is what I have looked at now and the example app doesn't really provide any UI cues but maybe we could change that

The troubleshooting section is very relevant for this package - all of those items should be called out here (they tripped me up during development at least...)

Beyond that I want to look at the code they provide and see if they are doing anything special

@mikehardy mikehardy added the enhancement New feature or request label May 8, 2019
@vforvasile
Copy link

hey @mikehardy, any updates on this?

@mikehardy
Copy link
Owner Author

Hmm - no I haven't moved it forward any - but the library does support basically all the uses cases, and the example app provides the raw material to do it (like, a progress event callback so you can update a graphical progress bar etc.

In the app where I use the library I check update status during bootstrap and route to an update page that does the app similar to their "immediate update" example.

If I were to sum up the idea of this bug it would be really to provide a more polished example, but it does not really add functionality - there's nothing extra required in the library itself I don't think?

@mikehardy
Copy link
Owner Author

For completeness since I mention the troubleshooting section - those are almost all issues for active development where you don't have .apk splits on ABIs with different version code streams on your local debug installs, then you attempt to install the release version (different certificate) or you attempt to go from release to debug version (usually a version code regression). They aren't bugs, they are just annoying while developing. But even then after download the library makes that data available prior to install I believe, so you can message appropriately (e.g. "Hey this update attempt will likely fail because of certificate mismatch" or version code downgrade etc)

@BoKKeR
Copy link

BoKKeR commented Jul 1, 2020

One of the interesting features they mention is the ability to use the core library to check if there is a published play store update. I don't think this is possible with this package in its current implementation.

@mikehardy
Copy link
Owner Author

@BoKKeR I may be misunderstanding, but that's almost the entire purpose of this library, and how I use it? I use it to check if there is a published update, then behave accordingly

@BoKKeR
Copy link

BoKKeR commented Jul 1, 2020

but the update check for android has to be from an external URL. From my understanding from the example project the library does not check the play store version but uses an external url.

@mikehardy
Copy link
Owner Author

That is true, the point of this module at the moment is mostly to handle the "distribution outside of the play store" use case. I could see checking the version code(s) available from the play store being a useful counterpart. I'd be happy to merge a PR that implemented it

@BoKKeR
Copy link

BoKKeR commented Jul 1, 2020

I have been using this library that does exactly that, found it after I commented here. https://github.com/kimxogus/react-native-version-check

@mikehardy
Copy link
Owner Author

Yeah I've seen that one before but I always hesitate when I see "looking for maintainers" on the readme and a low level of commits even though that module appears relatively solid.

The version check itself from play store is trivial but it unfortunately only picks up the "public version" and can't see the version code

https://github.com/kimxogus/react-native-version-check/blob/master/packages/react-native-version-check/src/providers/playStore.js#L24-L53

I find all of this distasteful honestly. There's no official API, we're scraping a web page out of our control.
I vastly prefer a published descriptor like the one this app uses. It's a shame Google doesn't publish the information necessary via a machine consumable interface like the App Store does with it's JSON

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants