Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split into two packages: seperate the munge functions from the download functions #39

Open
NathanSkene opened this issue Dec 31, 2020 · 0 comments

Comments

@NathanSkene
Copy link

Hi Mike,

I was looking into making a new package based on an existing function for munging sumstats that I'd written (MAGMA_Celltyping/format_sumstats_for_magma.r at master · NathanSkene/MAGMA_Celltyping). Thought I'd have a look around for whether anyone had recently built something with similar functionality and came across your package. It looks like you've done a tremendous job.

My sense is that the utility of what you've done could be bolstered by splitting it in two:

    1. A GWAS munging package, which takes a path to a GWAS file along with a set of arguments, and parses it as required
    1. A workflow with associated data files for using the package to format >200 GWAS summary statistics files

I think this would be useful in that it would allow for more clearly demarcated documentation & continuous integration for the munging function.

Would be interested to get your thoughts on doing this. Happy to muck in to get this done if useful, I'd love to be able to replace my existing function with something more reliable and better documented!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant