You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be a "nice to have" to someday pass pyright. We currently pass all unit tests using beartype or typeguard as of #2188 so type hints reflect the values passed in unit tests. I'd like to keep type hint stuff contained to this issue to avoid being overwhelmed, and any PR's fixing any of these are very welcome! Currently:
If anyone is interested in contributing a great place to start would be fixing a single file, i.e.:
mikedh@orion:trimesh$ pyright trimesh/sample.py
/home/mikedh/trimesh/trimesh/sample.py
/home/mikedh/trimesh/trimesh/sample.py:62:18 - error: No overloads for "cumsum" match the provided arguments (reportCallIssue)
/home/mikedh/trimesh/trimesh/sample.py:62:28 - error: Argument of type "ArrayLike | Unknown | None" cannot be assigned to parameter "a" of type "ArrayLike" in function "cumsum" (reportArgumentType)
/home/mikedh/trimesh/trimesh/sample.py:112:33 - error: "uv_vectors" is possibly unbound (reportPossiblyUnboundVariable)
/home/mikedh/trimesh/trimesh/sample.py:113:45 - error: "uv_origins" is possibly unbound (reportPossiblyUnboundVariable)
/home/mikedh/trimesh/trimesh/sample.py:211:5 - error: Expression with type "tuple[Unknown, Unknown, Unknown | None] | tuple[Unknown, Unknown]" cannot be assigned to target tuple
Type "tuple[Unknown, Unknown, Unknown | None]" is incompatible with target tuple
Tuple size mismatch; expected 2 but received 3 (reportAssignmentType)
5 errors, 0 warnings, 0 informations
The text was updated successfully, but these errors were encountered:
Hey @wenbc21 I've been tweaking the types when it affects me but there's no major effort on these. Beartype catches egregious violations in tests, but mypy/pylance would still need quite a bit of work. PR's would be great!
It would be a "nice to have" to someday pass
pyright
. We currently pass all unit tests usingbeartype
ortypeguard
as of #2188 so type hints reflect the values passed in unit tests. I'd like to keep type hint stuff contained to this issue to avoid being overwhelmed, and any PR's fixing any of these are very welcome! Currently:If anyone is interested in contributing a great place to start would be fixing a single file, i.e.:
The text was updated successfully, but these errors were encountered: