Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Covers rendering ontop of other tmux windows when unfocused #93

Closed
teaperr opened this issue Oct 10, 2024 · 4 comments · Fixed by #95
Closed

Covers rendering ontop of other tmux windows when unfocused #93

teaperr opened this issue Oct 10, 2024 · 4 comments · Fixed by #95

Comments

@teaperr
Copy link

teaperr commented Oct 10, 2024

Expected Behavior

Rendered covers to be not visible when rmpc is on an unfocused tmux window

Actual Behavior

When rmpc is open in another window in tmux and the song changes, the cover will be rendered on top of the current tmux pane until the current rmpc instance is quit.

Steps to reproduce:

  1. Open two tmux windows.
  2. Run rmpc in one of them.
  3. Play music.
  4. Move to the other window.
  5. run "rmpc next".

Specifications

Version: rmpc 0.4.0
Platform: Nixos Unstable
Additional info: 
    Terminal: Alacritty 0.13.2

Screenshots:

image

@mierak
Copy link
Owner

mierak commented Oct 10, 2024

Right, this happens because ueberzugpp runs in a separate process and rmpc does not detect that it is not in an active tmux pane. I will see if I can somehow detect that.
Anyway, this should really only happen in terminals not supported by other protocols like kitty.

@mierak
Copy link
Owner

mierak commented Oct 10, 2024

There is also related issue jstkdng/ueberzugpp#213 and pull request jstkdng/ueberzugpp#215 on ueberzugpp side which could resolve this issue.

@mierak
Copy link
Owner

mierak commented Oct 14, 2024

Fixed by #95
Unfortunately the fix is not perfect. When you repeat your steps to reproduce and then switch back to rmpc, the album art will be the same as when you have moved to the other window. Simply switching to another tab in rmpc and back will refresh it though.

I will eventually improve on this, but this should make it at least usable.

@teaperr
Copy link
Author

teaperr commented Oct 17, 2024

great, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants