Header as pane

[abiud254]

Description

I've seen what you've done with the lyrics and implemented it as a pane.
It would be great if the same could be done with the header to allow it be positioned at the bottom together with the progress bar and keeping its row customisations of course.

Proposed solution

Implement the header as a pane similar to queue, album art and lyrics.

[mierak]

I definitely want to do something about making them configurable. I dont have specific implementation in mind yet, but am unsure whether making them into panes is the way.

[abiud254]

I also wanted to ask about the browser_song_format. In the documentation it's stated it takes the same format as song_table_format. Does this mean it can have columns as well and you can use properties on it as well, cause I tried and it didn't work.

I also tried altering album_art_position and album_art_width_percent, and nothing changed.

Also, styling (kind: Property(Status(Bitrate))) like so (kind: Property(Status(Bitrate)), style: (fg: "red", modifiers: "Bold")), didn't apply any sort of styling.

[mierak]

I also tried altering album_art_position and album_art_width_percent, and nothing changed.

Those two are deprecated in favor of the tabs config which does the same and more. My bad on not pruning them properly from the docs, will fix that.

I also wanted to ask about the browser_song_format. In the documentation it's stated it takes the same format as song_table_format.

No, it just means that the it takes the same formatters as the song_table_format except with styles being ignored, but I see how its misleading, will also fix that. You can check the default theme at the bottom to see what its supposed to look like.

Also, styling (kind: Property(Status(Bitrate))) like so (kind: Property(Status(Bitrate)), style: (fg: "red", modifiers: "Bold")), didn't apply any sort of styling.

That is a genuine bug with Bitrate and Crossfade props (and maybe others), will fix that in a bit

Thanks for the feedback!

[mierak]

The styles not working fixed in #192. All mentions of album_art_position and album_art_width_percent were removed too.

[abiud254]

No, it just means that the it takes the same formatters as the song_table_format except with styles being ignored, but I see how its misleading, will also fix that.

I guess I was confused as to what counts as styles and formatters. I was just going over the documentation for song_table_format and thought those options were available to browser_song_format as well.

I just wish it was clearer which ones work for browser_song_format.