Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several bugs with t!set and t!setuser #81

Open
cobrabr opened this issue Dec 1, 2021 · 6 comments
Open

Several bugs with t!set and t!setuser #81

cobrabr opened this issue Dec 1, 2021 · 6 comments

Comments

@cobrabr
Copy link

cobrabr commented Dec 1, 2021

The screenshots below illustrate a few of the problems I found trying to set time zone, both for myself (with t!set) and for other users (with t!setuser).

Using time zone codes and UTC/GMT codes:

  • EDT is the only correct one here (and even then, not exactly, since we're not in Daylight Savings Time anymore).
    image

  • 'UTC-8' is correct here, the rest isn't.
    image
    image
    image
    image

Dealing with ambiguous city names

  • Not sure where the bot is getting "Central Time" from "Barcelona" or "CET" here. Trying to be more specific (as the screenshot shows) doesn't work. I tried used quotes, but that doesn't work, either.
    image

  • This only applies to t!setuser; t!set works with both city, country and fully-spelled time zones.
    image

@zsawyer
Copy link

zsawyer commented Dec 11, 2021

Section 1 relates to #79: possibly duplicate.

@bouncingmolar
Copy link

I tested the setuser bug.

Setuser only recognises place names that have one word.

New Zealand. Barcelona, Spain. South Korea. North Carolina would trigger the bug.

The problem is t!setuser user place1 place2 the bot reads name=(name place1) location=(place 2).

The problem with locations containing more than one word doesn't seem to affect t!set

@bouncingmolar
Copy link

bouncingmolar commented Dec 12, 2021

The other issues mentioned are described in the bot instructions. They will not be fixed. The work around is to use City/country names. Tell your members this or setuser correct them.

One problem with setting UTC offsets and time zone codes is that they won't adjust when daylight changes to summer time so half the time the time will be wrong.

I.e. if you set EDT, it won't change to EST when it should.

@cobrabr
Copy link
Author

cobrabr commented Dec 12, 2021

Sounds good. The only reason I tried to use time zone codes or UTC offsets was to try and circumvent the problem with place names that have more than one word.

@bouncingmolar
Copy link

A work around for setuser (because t!set Barcelona, Spain works). Is to try a nearby City or just Spain eg. t!setuser Spain or t!setuser stiges (a town near Barcelona) or Andorra. Barcelona doesn't work by itself because it clashes with Barcelona in Venezuela, England, Phillipines........ Etc. At least until the bug is fixed to allow spaces

@cobrabr
Copy link
Author

cobrabr commented Dec 15, 2021

Yep, that's what I did: I used Madrid. Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants