Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows-bindgen should support Rust edition 2024 #3391

Closed
kennykerr opened this issue Dec 13, 2024 · 4 comments · Fixed by #3393
Closed

windows-bindgen should support Rust edition 2024 #3391

kennykerr opened this issue Dec 13, 2024 · 4 comments · Fixed by #3393
Labels
enhancement New feature or request

Comments

@kennykerr
Copy link
Collaborator

There appear to be a bunch of new warnings to deal with...

@kennykerr kennykerr added the enhancement New feature or request label Dec 13, 2024
@kennykerr
Copy link
Collaborator Author

I really don't want to switch the edition - the last edition update was brutal - but hopefully we can find a way to at least test this and future-proof windows-rs for the inevitable. 🙂

@kennykerr
Copy link
Collaborator Author

This is the most vocal warning.

https://doc.rust-lang.org/nightly/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html

I can probably begin validation against this directly using:

[workspace.lints.rust]
unsafe_op_in_unsafe_fn = "warn"

Also cargo fix --edition helps but is a little over eager.

@kennykerr
Copy link
Collaborator Author

Also, Rust edition 2024 requires Rust 1.85 as the MSRV so we won't be able to actually switch any time soon.

@kennykerr kennykerr changed the title Test with edition = "2024" windows-bindgen should support Rust edition 2024 Dec 13, 2024
@kennykerr
Copy link
Collaborator Author

Testing locally, #3393 appears to unblock adoption of windows-rs crates and code gen for use with Rust 2024 without any warnings. I'll leave windows-rs itself on edition 2021 for now but I think this issue can be closed with #3393.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant