Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User settings don't get overridden by workspace settings when default value is used #65290

Closed
SetTrend opened this issue Dec 18, 2018 · 2 comments

Comments

@SetTrend
Copy link

SetTrend commented Dec 18, 2018

Issue Type: Bug

After having changed a setting's value in user settings, it's not possible to override the changed value with the default VS Code value in workspace settings:

settings 1

settings 2

settings 3

Current Behaviour

VS Code doesn't set overrides for default values.

Desired Behaviour

User settings differ from user to user, whereas workspace settings don't.

Adding a workspace setting tells the team that a particular setting is mandatory for the project, no matter what the actual user settings are.

So any workspace setting that's in the workspace settings settings.json file must not be automatically removed. Only when removing is explicitly desired.

Hence ...

  1. Setting any value in the Workspace Settings editor should - regardless of the actual value - always be added to the corresponding workspace settings settings.json file.

  2. I suggest to add a Remove button to each setting in Workspace Settings editor that's only visible next to each setting that's present in the corresponding settings.json file in the Workspace Settings editor. Clicking that button should remove that setting from the workspace settings settings.json file.


VS Code version: Code 1.30.0 (c6e592b, 2018-12-11T22:29:11.253Z)
OS version: Windows_NT x64 10.0.17134

Extensions (8)
Extension Author (truncated) Version
vscode-twig-pack baj 1.0.0
gitlab-workflow fat 1.5.1
vscode-firefox-debug hbe 1.6.0
vscode-language-pack-de MS- 1.27.2
Go ms- 0.7.0
PowerShell ms- 1.10.1
debugger-for-chrome msj 4.11.1
markdown-all-in-one yzh 1.8.0
@SetTrend
Copy link
Author

Closed as duplicate of #58038.

@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant