Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start native repl command should put the focus in input box #24451

Closed
amunger opened this issue Nov 15, 2024 · 1 comment
Closed

Start native repl command should put the focus in input box #24451

amunger opened this issue Nov 15, 2024 · 1 comment
Assignees
@amunger @anthonykim1
Labels
area-repl bug Issue identified by VS Code Team member as probable bug verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2024

Comments

@amunger
Copy link

amunger commented Nov 15, 2024 •
edited
Loading

We recently changed the focus behavior to keep focus in a text editor when sending code to the REPL, but running the start REPL command actually still should send focus to the new editor.

cc @anthonykim1
@amunger amunger added area-repl bug Issue identified by VS Code Team member as probable bug labels Nov 15, 2024
@amunger amunger self-assigned this Nov 15, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Nov 15, 2024
@amunger amunger removed the triage-needed Needs assignment to the proper sub-team label Nov 15, 2024
@amunger amunger self-assigned this Nov 15, 2024
@amunger amunger mentioned this issue Nov 15, 2024
Closed
anthonykim1 added a commit to anthonykim1/vscode-python that referenced this issue Nov 18, 2024
@anthonykim1
co-authored from @amunger via microsoft#24451
140771b
@anthonykim1
Copy link

This is closed via: #24148
verification steps:

  1. Latest pre-release Python extension
  2. Run command: Run native REPL
  3. Observe focus is on the input box of the native repl and not the editor itself.

@anthonykim1 anthonykim1 added this to the November 2024 milestone Nov 22, 2024
@anthonykim1 anthonykim1 added the verification-needed Verification of issue is requested label Nov 22, 2024
@amunger amunger added the verified Verification succeeded label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amunger amunger

@anthonykim1 anthonykim1

Labels
area-repl bug Issue identified by VS Code Team member as probable bug verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2024
Development

Successfully merging a pull request may close this issue.

pass through param to set focus on the REPL editor microsoft/vscode-python
2 participants
@amunger @anthonykim1