Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infinite error dialogs with GH account mixup #6245

Closed
amunger opened this issue Sep 24, 2024 · 2 comments
Closed

infinite error dialogs with GH account mixup #6245

amunger opened this issue Sep 24, 2024 · 2 comments
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
October 2024

Comments

@amunger
Copy link

amunger commented Sep 24, 2024

Testing #229420

Not quite sure how I got here, but when trying to play around with multiple accounts, opening the GHPR view just streams in errors:

Recording 2024-09-24 at 11 57 05
@TylerLeonhardt TylerLeonhardt transferred this issue from microsoft/vscode Sep 25, 2024
@TylerLeonhardt
Copy link
Member

I think this is an issue with the PR extension. @alexr00 are we handling vscode.authentication.onDidChangeSessions correctly?

@TylerLeonhardt TylerLeonhardt removed their assignment Sep 25, 2024
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Sep 26, 2024
@alexr00 alexr00 added this to the October 2024 milestone Sep 26, 2024
@alexr00
Copy link
Member

alexr00 commented Oct 3, 2024

Will be fixed by #6255

@alexr00 alexr00 closed this as completed Oct 3, 2024
@amunger amunger added the verified Verification succeeded label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
October 2024
Development

No branches or pull requests
3 participants
@amunger @TylerLeonhardt @alexr00