Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show some indication that mypy is running #193

Open
DetachHead opened this issue Sep 15, 2021 · 6 comments
Open

show some indication that mypy is running #193

DetachHead opened this issue Sep 15, 2021 · 6 comments
Labels
feature-request Request for new features or functionality needs PR

Comments

@DetachHead
Copy link
Contributor

DetachHead commented Sep 15, 2021

mypy is extremely slow on windows. it would be nice if there was some sort of indication to show when it's still running, like it does with the formatters:

image
image

@DetachHead DetachHead added triage-needed feature-request Request for new features or functionality labels Sep 15, 2021
@karthiknadig
Copy link
Member

Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 5 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.

@DetachHead
Copy link
Contributor Author

I don't understand why valid issues can just be closed for not having enough upvotes. Why not just leave it open and mark it as low priority or accepting PRs in case someone else wants to contribute

@brettcannon
Copy link
Member

@DetachHead because every line of code we accept has a maintenance cost, so we can't afford to accept every feature request that someone may want to give us a PR for. And leaving an issue open forever can make people think we would accept a PR when we actually may not.

Asking for votes gives us some form of a signal as to how important something is to the community, especially with a time limit as an issue can collect a lot of upvotes over years but that doesn't mean it's as popular as something that gets more votes in a short amount of time.

@byehack
Copy link

byehack commented Oct 6, 2021

it also would be great with something like Formatting toggle for manually linting.

@brettcannon
Copy link
Member

Thank you to everyone who upvoted this issue! Since the community showed interest in this feature request we will leave this issue open as something to consider implementing at some point in the future.

We do encourage people to continue 👍 the first/opening comment as it helps us prioritize our work based on what the community seems to want the most.

@karthiknadig karthiknadig transferred this issue from microsoft/vscode-python Oct 31, 2023
@karthiknadig karthiknadig self-assigned this Oct 31, 2023
@karthiknadig karthiknadig removed their assignment Jan 18, 2024
@niderhoff
Copy link

niderhoff commented Apr 24, 2024

That is a great idea, I always wonder if mypy is doing something or just broken. And then suddenly the markers get updated in the code.

I would suggest using a spinner in the status bar, similar to the git indicator:
image

Clicking the status bar element could also enable the option to enable/disable.

The popup you gave as an example is (in my personal opinion) super annoying and I think it implies that the user should wait for it to finish before working (learned behaviour from how the other popups work with formatters, after save actions etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality needs PR
Projects
None yet
Development

No branches or pull requests

5 participants