feat: added FileSystemWatcher for pyproject.toml #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xytian315
changed the title
karthiknadig
requested changes
Sep 26, 2023
src/extension.ts
Outdated
| @@ -44,6 +45,18 @@ export async function activate(context: vscode.ExtensionContext): Promise<void> | |||
| } | |||
| }; | |||
|
|
|||
| const workspaceFolder = vscode.workspace.workspaceFolders?.[0]; | |||
There was a problem hiding this comment.
You will need to do this on each of the workspace folders.
src/extension.ts
Outdated
|
|
||
| if (workspaceFolder) { | ||
| const fullPath = `${workspaceFolder.uri.fsPath}/pyproject.toml`; | ||
| watcher = vscode.workspace.createFileSystemWatcher(fullPath); |
There was a problem hiding this comment.
The watcher should be added to context.subscriptions so it can be disposed.
src/extension.ts
Outdated
|
|
||
| watcher.onDidChange((uri) => { | ||
| console.log('pyproject.toml changed'); | ||
| vscode.commands.executeCommand('mypy-type-checker.restart', uri.fsPath); |
There was a problem hiding this comment.
You can directly call the restart method that is available in this context.
Suggested change
| vscode.commands.executeCommand('mypy-type-checker.restart', uri.fsPath); | |
| await runServer(); |
There was a problem hiding this comment.
Thanks for suggestions. please check new commit.
|
@microsoft-github-policy-service agree |
karthiknadig
force-pushed
the
122-watch-pyproject
branch
from
f1ad910 to
24b2991
Compare
|
@xytian315 Sorry for the delayed response on this. I have refactored the code to be simpler for our case. |
karthiknadig
force-pushed
the
122-watch-pyproject
branch
from
24b2991 to
c39f0d9
Compare
|
Closing as stale, we can re-open this, if you want to continue working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #122